Requirements for Contributing a Bug Fix

• Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• The pull request must only fix an existing bug. To contribute other changes, you must use a different template. You can see all templates at https://github.com/atom/.github/tree/master/.github/PULL_REQUEST_TEMPLATE.
• The pull request must update the test suite to demonstrate the changed functionality. For guidance, please see https://flight-manual.atom.io/hacking-atom/sections/writing-specs/.
• After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see https://github.com/atom/.github/tree/master/CONTRIBUTING.md#pull-requests.

Identify the Bug

Similar to #87, building is broken in FreeBSD for 2 reasons:

1. The OS is not recognized by the build system.
2. hunspell won't build cleanly under LLVM/Clang.

Description of the Change

I would really like to make this change support OpenBSD as #87 reports, but given that I don't have a VM available at the moment, I limited my changes to FreeBSD (that I can test).

This PR includes 2 changes:

1. Make freebsd a recognizable platform alongside mac, linux and win. The logic is identical to Linux, since nothing special is required.
2. Partially backport hunspell/hunspell@be3b8d9#diff-0dd29bfd51e6c6fdadebc9b96923c5c6 and hunspell/hunspell@dd3a71c#diff-0dd29bfd51e6c6fdadebc9b96923c5c6. Hunspell have already fixed the build issue upstream, but the version included with spellchecker is not up to date. Instead of pulling in all the changes from upstream, include the must-haves that unbreak the build.

Alternate Designs

Ideally, we could update hunspell to the latest version. However that might be a big change, given that the last time that the vendor directory was updated was 6 years ago.

With this in mind, I tried to pick the minimum amount of changes that will unbreak the build and minimize the risk of breakage.

Possible Drawbacks

I am not aware of any drawbacks. Given that this is just following the upstream commits, this shouldn't have any negative impact.

Verification Process

Verified that the build works, and that the unit tests still pass.

$ yarn test
yarn run v1.16.0
$ jasmine-focused --captureExceptions --coffee spec/
..........................................................................................................................................

Finished in 13.619 seconds
138 tests, 184 assertions, 0 failures, 0 skipped


Done in 14.37s.

Release Notes

• node-spellchecker can now be built under FreeBSD